[PATCH] D157700: [GlobalIsSel] Allow using PatFrags with multiple defs as the root of a combine rule

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/patfrag-errors.td:266
+    [
+      (pattern (G_UNMERGE_VALUES $foo, $z, $y))
+    ]>;
----------------
It's somewhat confusing all the defs go to the right of the opcode name unlike in the actual mir


================
Comment at: llvm/utils/TableGen/GlobalISelCombinerMatchTableEmitter.cpp:816
+  std::vector<InstructionOperand> Ops;
+  for (unsigned K = 0; K < getNumInstDefs(); ++K)
+    Ops.push_back(getOperand(K));
----------------
this could just return an ArrayRef?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157700/new/

https://reviews.llvm.org/D157700