[PATCH] D158084: [AArch64] Stack probing for function prologues

[Momchil Velikov via Phabricator via llvm-commits]

chill added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1809
+    // This space doesn't need stack probing, because it will all be written to
+    // when saving the CSRs.
+    emitFrameOffset(
----------------
efriedma wrote:
> This comment doesn't sound right.  Probing isn't just about making sure everything is probed before we leave the prologue; we also need to make sure probes are triggered in the correct order.
Yes, I'm planning to look at it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158084/new/

https://reviews.llvm.org/D158084