[PATCH] D158084: [AArch64] Stack probing for function prologues

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Can we integrate Windows and non-Windows stack probing, to the extent that makes sense?  (I mean, the actual code sequences and register usage are obviously going to be different, but using the same overall logic for when to trigger probing and the amount to probe would make the code easier to understand.)



================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1809
+    // This space doesn't need stack probing, because it will all be written to
+    // when saving the CSRs.
+    emitFrameOffset(
----------------
This comment doesn't sound right.  Probing isn't just about making sure everything is probed before we leave the prologue; we also need to make sure probes are triggered in the correct order.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158084/new/

https://reviews.llvm.org/D158084