[PATCH] D157657: [RISCV] Support R_RISCV_SET_ULEB128/R_RISCV_SUB_ULEB128 for .uleb128 directives

[Kito Cheng via Phabricator via llvm-commits]

kito-cheng added a comment.

> We do not conservatively reserve 10 bytes (maximum size of an uleb128
> for uint64_t) as that would pessimize DWARF v5
> DW_LLE_offset_pair/DW_RLE_offset_pair, nullifying the benefits of
> introducing R_RISCV_SET_ULEB128/R_RISCV_SUB_ULEB128 relocations.

That fixed one of major issue in my version (D142880 <https://reviews.llvm.org/D142880>), it will always reserve 10 bytes instead of just reserve enough byte, and apparently I didn't handle handle debug info properly.

RISC-V part LGTM, thanks :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157657/new/

https://reviews.llvm.org/D157657