[PATCH] D157943: [GlobalISel][Mips] Correct corner case in G_UADDE legalization.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 15 11:11:22 PDT 2023
arsenm added inline comments.
================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:3448
+ auto Res_ULT_LHS = MIRBuilder.buildICmp(CmpInst::ICMP_ULT, CondTy, Res, LHS);
+ MIRBuilder.buildSelect(CarryOut, Res_EQ_LHS, CarryIn, Res_ULT_LHS);
----------------
Should probably use an and here, that's more canonical for booleans plus that seems to be what the DAG does
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157943/new/
https://reviews.llvm.org/D157943
More information about the llvm-commits
mailing list