[PATCH] D155633: [OpenMP][OpenMPIRBuilder] Add kernel launch codegen to emitTargetCall

Jan Sjödin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 14:02:44 PDT 2023


jsjodin added inline comments.


================
Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:5167
   auto Iter = F->getEntryBlock().rbegin();
-  CallInst *Call = dyn_cast<CallInst>(&*(++Iter));
-  EXPECT_NE(Call, nullptr);
+  F->dump();
+  EXPECT_TRUE(isa<BranchInst>(&*(Iter)));
----------------
kiranchandramohan wrote:
> Nit: leftover debug?
> Nit: leftover debug?

Yes, thank you for finding that. I will remove this and update the parameter names CreateDefaultMapInfos. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155633/new/

https://reviews.llvm.org/D155633



More information about the llvm-commits mailing list