[PATCH] D155633: [OpenMP][OpenMPIRBuilder] Add kernel launch codegen to emitTargetCall

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

In D155633#4586255 <https://reviews.llvm.org/D155633#4586255>, @jsjodin wrote:

> @kiranchandramohan did you have any more feedback about the patch?

I have not gone through the patch in detail. If you feel the patch is in good shape and @jdoerfert has not further comments you may go ahead.



================
Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:5167
   auto Iter = F->getEntryBlock().rbegin();
-  CallInst *Call = dyn_cast<CallInst>(&*(++Iter));
-  EXPECT_NE(Call, nullptr);
+  F->dump();
+  EXPECT_TRUE(isa<BranchInst>(&*(Iter)));
----------------
Nit: leftover debug?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155633/new/

https://reviews.llvm.org/D155633