[PATCH] D157770: [RISCV][GISel] Make s32 a legal type for RV64 for any operation that has a W version.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 09:22:24 PDT 2023


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM

For context, Craig and I chatted about general directions here for a good while on Friday.  This is not a high confidence statement that we'll definitely end up with i32 legal on RV64.  It's instead a low confidence guess as to where SDAG will be in about a year.  If it turns out we're wrong, we'll reverse direction and move GISEL towards the current model that SDAG is using.  We're so far from O3 <https://reviews.llvm.org/owners/package/3/> code quality on GISEL that we don't expect to hit the code quality questions in practice to well beyond that rough 1yr timeline.

So basically, if you're looking at this later and think we went the wrong direction, it's entirely possible you're right.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157770/new/

https://reviews.llvm.org/D157770



More information about the llvm-commits mailing list