[PATCH] D157800: [ValueTracking] Improve analysis of knownbits from incoming phi edges.

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:1470
           BasicBlock *TrueSucc, *FalseSucc;
           // TODO: Use RHS Value and compute range from its known bits.
           if (match(RecQ.CxtI,
----------------
foad wrote:
> I don't quite understand this TODO, but it seems *maybe* you have implemented what it was suggesting?
I interpretted it to mean use `computeKnownBits` on RHS instead of only accepting constant RHS.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157800/new/

https://reviews.llvm.org/D157800