[PATCH] D157800: [ValueTracking] Improve analysis of knownbits from incoming phi edges.

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

> Just fill in missing cases (TODO) for ugt, uge, sgt, sge,
> slt, and sle. These are all in the same spirit as ult/uge, but
> each of the other conditions have different constraints.

Update the description?



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:1470
           BasicBlock *TrueSucc, *FalseSucc;
           // TODO: Use RHS Value and compute range from its known bits.
           if (match(RecQ.CxtI,
----------------
I don't quite understand this TODO, but it seems *maybe* you have implemented what it was suggesting?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157800/new/

https://reviews.llvm.org/D157800