[PATCH] D157210: [symbolizer] Change reaction on invalid input

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff added a comment.

In D157210#4584361 <https://reviews.llvm.org/D157210#4584361>, @jhenderson wrote:

> My opinion is that if someone is in interactive mode and they get an error, it may make sense to exit llvm-symbolizer, rather than continue. How does this differ to the previous (prior to your patch) behaviour for other error cases (i.e. cases other than "missing an input file/address pair")?

This is behavior of `llvm-symbolizer` before this patch. Whenever it detects an invalid input it echoes the input and continue waiting on stdin. This behavior makes sense, - if the program got wrong command from interactive input, it can continue working because the next commands may do useful job.

Anyway, it is not `llvm-symbolizer` that caused the hang, it is blocking read in the test script, which waits input from the stream that is empty in the case of new `llvm-symbolizer`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157210/new/

https://reviews.llvm.org/D157210