[PATCH] D157210: [symbolizer] Change reaction on invalid input
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 14 03:31:28 PDT 2023
jhenderson added a comment.
Right, that's what I figured was the issue, but could you answer this part of my concern:
> [explain] why it isn't going to cause end-users hanging issues in practice
My opinion is that if someone is in interactive mode and they get an error, it may make sense to exit llvm-symbolizer, rather than continue. How does this differ to the previous (prior to your patch) behaviour for other error cases (i.e. cases other than "missing an input file/address pair")?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157210/new/
https://reviews.llvm.org/D157210
More information about the llvm-commits
mailing list