[PATCH] D157798: [ValueTracking] Add tests for deducing non-zero based for incoming phi-edges; NFC

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n marked an inline comment as done.
goldstein.w.n added inline comments.


================
Comment at: llvm/test/Analysis/ValueTracking/phi-known-nonzero.ll:211
+  ret i1 %r
+}
----------------
nikic wrote:
> Missing test for the equal successor case?
> 
> And unless I missed it, there is no test for swapped successors (F, T instead of T, F)?
> Missing test for the equal successor case?
What do you mean 'equal successor case'?
> And unless I missed it, there is no test for swapped successors (F, T instead of T, F)?
eq_non_zero2 and all the `*lt/*le` cases?
But added a failure case for this as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157798/new/

https://reviews.llvm.org/D157798