[PATCH] D157798: [ValueTracking] Add tests for deducing non-zero based for incoming phi-edges; NFC

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 13 01:05:04 PDT 2023


nikic added inline comments.


================
Comment at: llvm/test/Analysis/ValueTracking/phi-known-nonzero.ll:27
+
+define i1 @phi_ugeh_non_zero(i8 %x) {
+; CHECK-LABEL: @phi_ugeh_non_zero(
----------------
ugeh...


================
Comment at: llvm/test/Analysis/ValueTracking/phi-known-nonzero.ll:211
+  ret i1 %r
+}
----------------
Missing test for the equal successor case?

And unless I missed it, there is no test for swapped successors (F, T instead of T, F)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157798/new/

https://reviews.llvm.org/D157798



More information about the llvm-commits mailing list