[PATCH] D150144: cmake: add missing dependency on Attributes.inc
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 11 12:50:42 PDT 2023
mehdi_amini added a comment.
In D150144#4581168 <https://reviews.llvm.org/D150144#4581168>, @arphaman wrote:
> actually it should probably stay in the IR library as its implementation depends on other IR stuff
I don't know if PseudoProbe belongs to IR (does it contribute to defining LLVM IR?), but the argument seems odd: "everything" depends on IR and that's not a justification to put them there. Maybe I misunderstood your comment?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150144/new/
https://reviews.llvm.org/D150144
More information about the llvm-commits
mailing list