[PATCH] D150144: cmake: add missing dependency on Attributes.inc

[Alex Lorenz via Phabricator via llvm-commits]

arphaman added a comment.

In D150144#4578352 <https://reviews.llvm.org/D150144#4578352>, @arphaman wrote:

> The only reason why you need llvm/IR/Attributes.inc is because you're building the IR module when importing `llvm/IR/PseudoProbe.h` . It seems to me that `llvm/IR/PseudoProbe.h` could be moved out of IR and into another library that table gen can actually depend on instead, which seems sensible given that it doesn't depend on anything else in IR and other things in IR don't depend on it.

actually it should probably stay in the IR library as its implementation depends on other IR stuff, but you could split it out of the IR clang module into a separate module since its header is standalone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150144/new/

https://reviews.llvm.org/D150144