[PATCH] D157210: [symbolizer] Change reaction on invalid input
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 11 08:02:15 PDT 2023
MaskRay added inline comments.
================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:198
if (Name.empty())
- // Wrong name for module file.
- return false;
+ return makeStringError("input file name is incorrect");
if (HasBuildIDPrefix) {
----------------
`cannot be empty` seems better than `is incorrect`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157210/new/
https://reviews.llvm.org/D157210
More information about the llvm-commits
mailing list