[PATCH] D157210: [symbolizer] Change reaction on invalid input

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 08:00:53 PDT 2023


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h:36
   StringRef ModuleName;
-  std::optional<uint64_t> Address;
+  std::optional<uint64_t> Address = std::nullopt;
 };
----------------
remove this change. 

https://en.cppreference.com/w/cpp/utility/optional/optional
"1) Constructs an object that does not contain a value."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157210/new/

https://reviews.llvm.org/D157210



More information about the llvm-commits mailing list