[PATCH] D157541: [JITLink][AArch32] Implement ELF::R_ARM_JUMP24

Eymen Ünay via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 07:21:01 PDT 2023


Eymay added a comment.

In D157541#4574325 <https://reviews.llvm.org/D157541#4574325>, @sgraenitz wrote:

> Thanks!
>
> Is the test actually working right now? Since we always use indirection stubs and we only have a Thumb implementation right now, my quick assumption was that the `TargetSymbol` should always have the `ThumbSymbol` flag set (and thus always bail out). Maybe I find the time in the next days to look into it myself and give some informed feedback.

Yes it passes on my machine. I observe that TargetSymbol.hasTargetFlags(ThumbSymbol) outputs "0" in applyFixupArm so that might be the reason for not bailing out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157541/new/

https://reviews.llvm.org/D157541



More information about the llvm-commits mailing list