[PATCH] D157541: [JITLink][AArch32] Implement ELF::R_ARM_JUMP24
Stefan Gränitz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 9 12:44:56 PDT 2023
sgraenitz added a comment.
Thanks!
Is the test actually working right now? Since we always use indirection stubs and we only have a Thumb implementation right now, my quick assumption was that the `TargetSymbol` should always have the `ThumbSymbol` flag set (and thus always bail out). Maybe I find the time in the next days to look into it myself and give some informed feedback.
================
Comment at: llvm/lib/ExecutionEngine/JITLink/aarch32.cpp:412
+ return make_error<JITLinkError>("Branch relocation needs interworking "
+ "stub when bridging to ARM: " +
+ StringRef(G.getEdgeKindName(Kind)));
----------------
Nit: bridging to Thumb
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157541/new/
https://reviews.llvm.org/D157541
More information about the llvm-commits
mailing list