[PATCH] D157679: [AArch64][GISel] Extend lowering for fp round intrinsics.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4919-4926
+  case TargetOpcode::G_FCEIL:
+  case TargetOpcode::G_FFLOOR:
+  case TargetOpcode::G_FNEARBYINT:
+  case TargetOpcode::G_FRINT:
+  case TargetOpcode::G_INTRINSIC_ROUND:
+  case TargetOpcode::G_INTRINSIC_ROUNDEVEN:
+  case TargetOpcode::G_INTRINSIC_TRUNC:
----------------
I'm surprised these are missing


================
Comment at: llvm/test/CodeGen/AArch64/fcvt.ll:158-161
-; CHECK-LABEL: ceil_v3f32:
-; CHECK:       // %bb.0: // %entry
-; CHECK-NEXT:    frintp v0.4s, v0.4s
-; CHECK-NEXT:    ret
----------------
This is worse


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157679/new/

https://reviews.llvm.org/D157679