[PATCH] D157514: [ARM] Set preferred function alignment

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

Can you improve the summary to explain why this is being done? Its the same reasons as we align loops.

Should this be done for all cpus? I can see how that would make sense, but as far as I understand you are only really aiming for M-class devices. And we haven't in the past aligned loops for v6m devices (or some of the higher end v7m devices).



================
Comment at: llvm/test/CodeGen/ARM/preferred-function-alignment.ll:1
 ; RUN: llc -mtriple=arm-none-eabi -mcpu=generic < %s | FileCheck --check-prefixes=ALIGN-GENERIC,CHECK %s
 ; RUN: llc -mtriple=arm-none-eabi -mcpu=cortex-m23 < %s | FileCheck --check-prefixes=ALIGN,CHECK %s
----------------
It might be better to make this an Arm CPU deliberately (as opposed to thumb), as opposed to generic. I believe that is what this is testing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157514/new/

https://reviews.llvm.org/D157514