[PATCH] D157515: [GlobalISel] Also set dead flags of implicit defs added by BuildMI

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 08:09:37 PDT 2023


Pierre-vh created this revision.
Pierre-vh added reviewers: arsenm, aemerson, RKSimon.
Herald added subscribers: kerbowa, pengfei, jvesely.
Herald added a project: All.
Pierre-vh requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

BuildMI automatically adds the implicit operands of the
instruction. This meant we couldn''t set the dead flag on
dead implicit defs in that case.

Fix it by introducing an opcode to mark a given implicit
def as dead.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157515

Files:
  llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutor.h
  llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutorImpl.h
  llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-lowering-swap-compare-operands.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-arith-extended-reg.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-arith-shifted-reg.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-binop.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-jump-table-brjt.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-ptr-add.mir
  llvm/test/CodeGen/AArch64/GlobalISel/sext-inreg-ldrow-16b.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/dead-scc-scalar-zext-pattern.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-abs.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-add.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-anyext.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-build-vector-trunc.v2s16.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-fabs.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-fneg.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-select.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-sext.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-zext.mir
  llvm/test/CodeGen/X86/GlobalISel/select-ashr-scalar.mir
  llvm/test/CodeGen/X86/GlobalISel/select-blsi.mir
  llvm/test/CodeGen/X86/GlobalISel/select-blsr.mir
  llvm/test/CodeGen/X86/GlobalISel/select-brcond.mir
  llvm/test/CodeGen/X86/GlobalISel/select-cmp.mir
  llvm/test/CodeGen/X86/GlobalISel/select-constant.mir
  llvm/test/CodeGen/X86/GlobalISel/select-leaf-constant.mir
  llvm/test/CodeGen/X86/GlobalISel/select-lshr-scalar.mir
  llvm/test/CodeGen/X86/GlobalISel/select-phi.mir
  llvm/test/CodeGen/X86/GlobalISel/select-shl-scalar.mir
  llvm/test/CodeGen/X86/GlobalISel/x86_64-select-zext.mir
  llvm/test/CodeGen/X86/switch-bit-test-unreachable-default.ll
  llvm/utils/TableGen/GlobalISelMatchTable.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157515.548630.patch
Type: text/x-patch
Size: 177614 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230809/eb6f23da/attachment-0001.bin>


More information about the llvm-commits mailing list