[PATCH] D157623: [lld][COFF] Remove incorrect flag from EHcont table

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 15:55:57 PDT 2023


rnk added a comment.

You can see where the eh cont table was added here: https://reviews.llvm.org/D99078



================
Comment at: lld/COFF/Writer.cpp:1799
     maybeAddRVATable(std::move(ehContTargets), "__guard_eh_cont_table",
-                     "__guard_eh_cont_count", true);
 
----------------
I think with this change the final parameter of `maybeAddRVATable` is completely dead. Would you please make a follow up change to remove the code for it?


================
Comment at: lld/COFF/Writer.cpp:1876
   if (hasFlag)
     tableChunk = make<RVAFlagTableChunk>(std::move(tableSymbols));
   else
----------------
We don't need RVAFlagTableChunk anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157623/new/

https://reviews.llvm.org/D157623



More information about the llvm-commits mailing list