[PATCH] D157623: [lld][COFF] Remove incorrect flag from EHcont table

Thu Aug 10 13:45:32 PDT 2023

duck-37 added inline comments.

================
Comment at: llvm/tools/llvm-readobj/COFFDumper.cpp:947
+  uint32_t Stride = Tables.GuardFlags >> 28;
+  PrintExtraCB PrintExtra = Stride == 1 ? PrintGuardFlags : nullptr;
+
----------------
mstorsjo wrote:
> This broke compilation with GCC:
> ```
> ../tools/llvm-readobj/COFFDumper.cpp: In member function ‘virtual void {anonymous}::COFFDumper::printCOFFLoadConfig()’:
> ../tools/llvm-readobj/COFFDumper.cpp:947:41: error: operands to ‘?:’ have different types ‘{anonymous}::COFFDumper::printCOFFLoadConfig()::<lambda(llvm::raw_ostream&, const uint8_t*)>’ and ‘std::nullptr_t’
>   947 |   PrintExtraCB PrintExtra = Stride == 1 ? PrintGuardFlags : nullptr;
>       |                             ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
> ```
Quick-fix pushed up just now. [Seems to have worked](https://lab.llvm.org/buildbot/#/builders/193/builds/36396).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157623/new/

https://reviews.llvm.org/D157623