[PATCH] D157567: PreISelIntrinsicLowering: Check RuntimeLibcalls instead of TLI for memory functions

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/Transforms/PreISelIntrinsicLowering/X86/load-relative.ll:1
-; RUN: opt -pre-isel-intrinsic-lowering -S -o - %s | FileCheck %s
+; RUN: opt -mtriple=x86_64-pc-linux-gnu -pre-isel-intrinsic-lowering -S -o - %s | FileCheck %s
 
----------------
paulkirth wrote:
> Why were `load-relative.ll` and `obj-arc.ll` made x86 specific tests? They seem like they should work on any platform. 
> 
> I'm not opposed to the change, but it's unclear to me what this accomplishes.
The test needs a TargetMachine to query the subtarget. It was weird this didn't have one before


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157567/new/

https://reviews.llvm.org/D157567