[PATCH] D157567: PreISelIntrinsicLowering: Check RuntimeLibcalls instead of TLI for memory functions

Paul Kirth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 10:13:07 PDT 2023


paulkirth accepted this revision.
paulkirth added a comment.
This revision is now accepted and ready to land.

Thanks for getting a patch out so quickly. This looks like it avoids the issue we were seeing in our build.



================
Comment at: llvm/test/Transforms/PreISelIntrinsicLowering/X86/load-relative.ll:1
-; RUN: opt -pre-isel-intrinsic-lowering -S -o - %s | FileCheck %s
+; RUN: opt -mtriple=x86_64-pc-linux-gnu -pre-isel-intrinsic-lowering -S -o - %s | FileCheck %s
 
----------------
Why were `load-relative.ll` and `obj-arc.ll` made x86 specific tests? They seem like they should work on any platform. 

I'm not opposed to the change, but it's unclear to me what this accomplishes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157567/new/

https://reviews.llvm.org/D157567



More information about the llvm-commits mailing list