[PATCH] D157599: [AMDGPU] Do not release VGPRs at -O0

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 03:47:42 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1039
     if (ST->getGeneration() >= AMDGPUSubtarget::GFX11 &&
+        MI.getMF()->getTarget().getOptLevel() != CodeGenOpt::None &&
         ScoreBrackets.getScoreRange(VS_CNT) != 0 &&
----------------
should also account for optnone on the function


================
Comment at: llvm/test/CodeGen/AMDGPU/release-vgprs.mir:24
+  define amdgpu_ps void @image_atomic() { ret void }
+...
+
----------------
need an optnone case


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157599/new/

https://reviews.llvm.org/D157599



More information about the llvm-commits mailing list