[PATCH] D157599: [AMDGPU] Do not release VGPRs at -O0

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 03:37:48 PDT 2023

foad created this revision.
Herald added subscribers: StephenFan, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl, arsenm.
Herald added a project: All.
foad requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

This was an oversight when the GFX11 early release VGPRs optimization
was reimplemented in D153279 <https://reviews.llvm.org/D153279>.

Sending the DEALLOC_VGPRS message is a performance optimization so there
is no need to do it at -O0. In addition it makes some kinds of post
mortem debugging hard or impossible, since VGPR values are no longer
available to inspect at the s_endpgm instruction.

  rG LLVM Github Monorepo



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157599.548956.patch
Type: text/x-patch
Size: 24096 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230810/6d6d596e/attachment.bin>

More information about the llvm-commits mailing list