[PATCH] D157500: [Thumb1] Use callee-saved register to adjust stack pointer

[Keith Walker via Phabricator via llvm-commits]

keith.walker.arm added inline comments.


================
Comment at: llvm/lib/Target/ARM/Thumb1FrameLowering.cpp:552
+    }
+
     if (AFI->shouldRestoreSPFromFP()) {
----------------
olista01 wrote:
> Please add an assertion to check that `ScratchRegister` has been set to something.
I'll simplify the assert in the branch which adjusts SP using FP.
The other uses of the ScratchRegister in emitPrologueEpilogueSPUpdate(() already has an assert if the ScratchRegister is used.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157500/new/

https://reviews.llvm.org/D157500