[PATCH] D157500: [Thumb1] Use callee-saved register to adjust stack pointer

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 07:31:02 PDT 2023


olista01 added a comment.

Do you have a test case for the situation where `r4` is not saved?



================
Comment at: llvm/lib/Target/ARM/Thumb1FrameLowering.cpp:552
+    }
+
     if (AFI->shouldRestoreSPFromFP()) {
----------------
Please add an assertion to check that `ScratchRegister` has been set to something.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157500/new/

https://reviews.llvm.org/D157500



More information about the llvm-commits mailing list