[PATCH] D157458: [X86][AMX] Fix virtual register traversing in case of GlobalIsel

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 06:47:05 PDT 2023


pengfei added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineRegisterInfo.h:677
   /// None of this condition is possible without GlobalISel for now.
-  /// In other words, if GlobalISel is not used or if the query happens after
+  /// In other words, if GlobalISel is not used and if the query happens after
   /// the select pass, using getRegClass is safe.
----------------
pengfei wrote:
> My understanding the `or` is correct, it looks to me like `if (!GlobalISel || AfterISel)`
Oh, I think and makes sense here. Sorry..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157458/new/

https://reviews.llvm.org/D157458



More information about the llvm-commits mailing list