[PATCH] D157355: [BOLT][DWARF] Always use new low_pc for exprloc
Alexander Yermolovich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 8 16:25:24 PDT 2023
ayermolo marked 2 inline comments as done.
ayermolo added inline comments.
================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:1153
}
- } else {
- // TODO: Re-do this as DWARF5.
----------------
Amir wrote:
> Is it correct to drop this else? I.e. for all non-DW_OP_{,GNU_}addrx forms is it ok to skip them?
> Looks like yes as the other forms are copied above.
Yes. Previously we copied old data, and then added existing index in to AddressTable. Now we create a new entry.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157355/new/
https://reviews.llvm.org/D157355
More information about the llvm-commits
mailing list