[PATCH] D157355: [BOLT][DWARF] Always use new low_pc for exprloc

[Amir Ayupov via Phabricator via llvm-commits]

Amir accepted this revision.
Amir added a comment.
This revision is now accepted and ready to land.

LGTM sans nits.



================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:1135-1136
                      "Invalid Operand Index.");
-              if (Expr.getCode() == dwarf::DW_OP_addrx) {
+              if (Expr.getCode() == dwarf::DW_OP_addrx ||
+                  Expr.getCode() == dwarf::DW_OP_GNU_addr_index) {
                 const uint32_t Index = AddrWriter->getIndexFromAddress(
----------------
Drop


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:1153
                 }
-              } else {
-                // TODO: Re-do this as DWARF5.
----------------
Is it correct to drop this else? I.e. for all non-DW_OP_{,GNU_}addrx forms is it ok to skip them?
Looks like yes as the other forms are copied above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157355/new/

https://reviews.llvm.org/D157355