[PATCH] D157430: Revert "[AggressiveInstCombine] Fold strcmp for short string literals"

Alexander Kornienko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 12:34:41 PDT 2023


alexfh created this revision.
alexfh added reviewers: xbolva00, asmok-g, kitaisreal.
Herald added a subscriber: hiraditya.
Herald added a project: All.
alexfh requested review of this revision.
Herald added a project: LLVM.

This reverts commit 5dde755188e34c0ba5304365612904476c8adfda <https://reviews.llvm.org/rG5dde755188e34c0ba5304365612904476c8adfda>,
cbfcf90152de5392a36d0a0241eef25f5e159eef <https://reviews.llvm.org/rGcbfcf90152de5392a36d0a0241eef25f5e159eef> and
8981520b19f2d2fe3d2bc80cf26318ee6b5b7473 <https://reviews.llvm.org/rG8981520b19f2d2fe3d2bc80cf26318ee6b5b7473> due to a miscompile introduced in
8981520b19f2d2fe3d2bc80cf26318ee6b5b7473 <https://reviews.llvm.org/rG8981520b19f2d2fe3d2bc80cf26318ee6b5b7473> (see
https://reviews.llvm.org/D154725#4568845 for details)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157430

Files:
  llvm/include/llvm/Analysis/ValueTracking.h
  llvm/include/llvm/Transforms/AggressiveInstCombine/AggressiveInstCombine.h
  llvm/lib/Analysis/ValueTracking.cpp
  llvm/lib/Transforms/AggressiveInstCombine/AggressiveInstCombine.cpp
  llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
  llvm/test/Transforms/AggressiveInstCombine/strcmp.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157430.548318.patch
Type: text/x-patch
Size: 32872 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230808/d320b380/attachment.bin>


More information about the llvm-commits mailing list