[PATCH] D156552: [MachineScheduler] Track physical register dependencies per-regunit

[Jay Foad via Phabricator via llvm-commits]

foad marked an inline comment as done.
foad added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/ScheduleDAGInstrs.h:91
   /// without any frees.
   using Reg2SUnitsMap =
       SparseMultiSet<PhysRegSUOper, identity<unsigned>, uint16_t>;
----------------
bjope wrote:
> This should perhaps be renamed as RegUnit2SUnitsMap now when when spare set key is a RegUnit and not a Reg.
> 
> Caused me some head-ache downstream until I found out that 
> ```
>         for (Reg2SUnitsMap::iterator I = DAG->Uses.find(*Subreg);
>              I != DAG->Uses.end(); ++I) {
> ```
> probably isn't working any longer unless I make some changes to use a RegUnit in that find call.
Good idea. Done in d9c0166f12f0231df0893a397326efb93935ed26.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156552/new/

https://reviews.llvm.org/D156552