[PATCH] D156552: [MachineScheduler] Track physical register dependencies per-regunit
Bjorn Pettersson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 7 14:29:26 PDT 2023
bjope added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/ScheduleDAGInstrs.h:91
/// without any frees.
using Reg2SUnitsMap =
SparseMultiSet<PhysRegSUOper, identity<unsigned>, uint16_t>;
----------------
This should perhaps be renamed as RegUnit2SUnitsMap now when when spare set key is a RegUnit and not a Reg.
Caused me some head-ache downstream until I found out that
```
for (Reg2SUnitsMap::iterator I = DAG->Uses.find(*Subreg);
I != DAG->Uses.end(); ++I) {
```
probably isn't working any longer unless I make some changes to use a RegUnit in that find call.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156552/new/
https://reviews.llvm.org/D156552
More information about the llvm-commits
mailing list