[PATCH] D155579: [Windows] Avoid using FileIndex for unique IDs on network mounts

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 05:07:56 PDT 2023


aaron.ballman added inline comments.


================
Comment at: llvm/lib/Support/Windows/Path.inc:740-741
 
+  bool PathCanonicalized;
+  PathCanonicalized = false;
+  if (Path.empty()) {
----------------
mstorsjo wrote:
> aaron.ballman wrote:
> > 
> Yes, I'd love to do that - but there are gotos that jump past this spot, and the gotos can't cross an initialization.
Ugh... "thanks" goto! :-D


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155579/new/

https://reviews.llvm.org/D155579



More information about the llvm-commits mailing list