[PATCH] D155579: [Windows] Avoid using FileIndex for unique IDs on network mounts

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: llvm/include/llvm/Support/FileSystem.h:238-239
   uint32_t FileIndexLow = 0;
+  uint64_t PathHash = 0;
+  bool ReliableFileIndex = true;
   #endif
----------------
aaron.ballman wrote:
> Some comments explaining that the hash is only expected to be valid if `ReliableFileIndex` is `false` may help.
Yep, that'd be useful, will add that!


================
Comment at: llvm/lib/Support/Windows/Path.inc:740-741
 
+  bool PathCanonicalized;
+  PathCanonicalized = false;
+  if (Path.empty()) {
----------------
aaron.ballman wrote:
> 
Yes, I'd love to do that - but there are gotos that jump past this spot, and the gotos can't cross an initialization.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155579/new/

https://reviews.llvm.org/D155579