[PATCH] D138135: [lld][ELF] Support LoongArch

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/Arch/LoongArch.cpp:162-163
+
+  if (negativeA)
+    result += 0x1000;
+  if (negativeA && !negativeB)
----------------
Don't you need to recompute `negativeA` after adding 0x1000 to `result? That yields a different result if the original `result` value happened to be 0x7fff'f000.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138135/new/

https://reviews.llvm.org/D138135