[PATCH] D157273: [GlobalISel] Add dead flags to implicit defs in ISel

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 14:15:56 PDT 2023


arsenm added a comment.

In D157273#4565233 <https://reviews.llvm.org/D157273#4565233>, @Pierre-vh wrote:

> A couple of things to note:
>
> - This is a bit naive, it only works on the `Record*` and doesn't test for subregs or RC, should it?

Probably can ignore this

> - One of the tradeoffs of doing this at the TableGen level is that we don't know about reserved registers. Do they matter in this case? How could we handle them?

It doesn't matter, dead flags shouldn't be set on reserved registers but also shouldn't matter


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157273/new/

https://reviews.llvm.org/D157273



More information about the llvm-commits mailing list