[PATCH] D157088: [AMDGPU][NFC] Refine representation of register intervals in SIInsertWaitcnts.

[Ivan Kosarev via Phabricator via llvm-commits]

kosarev added a comment.

> Personally I don't see much benefit to the "make no references to encodings" abstraction unless you are planning to change things, such that the interval endpoints are no longer register encoding values. Are you?

I don't know about much benefit, but think there is some. As the pass only really uses encodings as implementation detail of how register operands are translated to intervals, segregating everything related to them in a small function simplifies the conceptual picture to readers of this code. It also encourages using that new translation function instead of replicating code that retrieves and manipulates encodings directly, which as any other deduplication might be considered a good thing regardless of anticipated changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157088/new/

https://reviews.llvm.org/D157088