[PATCH] D157098: [VectorCombine][NFC][test] Supplement tests of the load-insert-store sequence

Mon Aug 7 04:30:08 PDT 2023

benshi001 added a comment.

In D157098#4565230 <https://reviews.llvm.org/D157098#4565230>, @nikic wrote:

> Is this test coverage for an upcoming patch or just more thorough coverage for the existing transform?

I plan to implement several `TODO`s in `VectorCombine`. And I hope this can be transformed in the future.

================
Comment at: llvm/test/Transforms/VectorCombine/AArch64/load-insert-store.ll:8
+; CHECK-LABEL: define void @load_insert_store_a
+; CHECK-SAME: (ptr [[A:%.*]], i32 [[B:%.*]]) {
+; CHECK-NEXT:  entry:
----------------
nikic wrote:
> benshi001 wrote:
> > benshi001 wrote:
> > > RKSimon wrote:
> > > > Was this generated by update_test_checks?
> > > Yes. All checks were auto generated by `update_test_checks`, without any manual modifcation.
> > I did not see `CHECK-SAME` in other test files, do we have to manually remove them ?
> This is the version 2 output of update_test_checks, which includes the function signature. Older tests don't.
So we should keep it as what it is ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157098/new/

https://reviews.llvm.org/D157098