[PATCH] D157098: [VectorCombine][NFC][test] Supplement tests of the load-insert-store sequence

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 04:01:08 PDT 2023


nikic added a comment.

Is this test coverage for an upcoming patch or just more thorough coverage for the existing transform?



================
Comment at: llvm/test/Transforms/VectorCombine/AArch64/load-insert-store.ll:8
+; CHECK-LABEL: define void @load_insert_store_a
+; CHECK-SAME: (ptr [[A:%.*]], i32 [[B:%.*]]) {
+; CHECK-NEXT:  entry:
----------------
benshi001 wrote:
> benshi001 wrote:
> > RKSimon wrote:
> > > Was this generated by update_test_checks?
> > Yes. All checks were auto generated by `update_test_checks`, without any manual modifcation.
> I did not see `CHECK-SAME` in other test files, do we have to manually remove them ?
This is the version 2 output of update_test_checks, which includes the function signature. Older tests don't.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157098/new/

https://reviews.llvm.org/D157098



More information about the llvm-commits mailing list