[PATCH] D156499: [InstCombine] Fold abs of known sign operand when source is sub
Allen zhong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 6 20:49:02 PDT 2023
Allen marked an inline comment as done.
Allen added inline comments.
================
Comment at: llvm/test/Transforms/InstCombine/abs-intrinsic.ll:578
cond.true:
%sub = sub nsw i8 %x, %y
----------------
goldstein.w.n wrote:
> Imo missing a test with `sge i8 %y, %x`. Also missing a test where the sub is in the false case (i.e `sgt %x, %y` but abs in false case).
Done, thanks! Added new cases sub_abs_sgeT_swap and sub_abs_sgeT_false
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156499/new/
https://reviews.llvm.org/D156499
More information about the llvm-commits
mailing list