[PATCH] D157210: [symbolizer] Change reaction on invalid input

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff created this revision.
sepavloff added reviewers: jhenderson, dblaikie, mysterymath, MaskRay, ikudrin.
Herald added a subscriber: hiraditya.
Herald added a project: All.
sepavloff requested review of this revision.
Herald added a project: LLVM.

If llvm-symbolizer finds a malformed command, it echoes it to the
standard output. New versions of binutils (starting from 2.39) allow to
specify an address by a symbols. Implementation of this feature in
llvm-symbolizer makes the current reaction on invalid input
inappropriate. Almost any invalid command may be treated as a symbol
name, so the right reaction should be "symbol not found" in such case.

The exception are commands that are recognized but have incorrect
syntax, like "FILE:FILE:". The utility must produce descriptive
diagnostic for such input and route it to the stderr.

This change implements the new reaction on invalid input and is a
prerequisite for implementation of symbol lookup in llvm-symbolizer.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157210

Files:
  llvm/docs/CommandGuide/llvm-symbolizer.rst
  llvm/docs/ReleaseNotes.rst
  llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
  llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp
  llvm/test/tools/llvm-symbolizer/debuginfod.test
  llvm/test/tools/llvm-symbolizer/file-prefix.test
  llvm/test/tools/llvm-symbolizer/flag-grouping.test
  llvm/test/tools/llvm-symbolizer/flush-output.s
  llvm/test/tools/llvm-symbolizer/functions.s
  llvm/test/tools/llvm-symbolizer/input-base.test
  llvm/test/tools/llvm-symbolizer/invalid-input-address.test
  llvm/test/tools/llvm-symbolizer/options-from-env.test
  llvm/test/tools/llvm-symbolizer/output-style-empty-line.test
  llvm/test/tools/llvm-symbolizer/output-style-json-code.test
  llvm/test/tools/llvm-symbolizer/output-style-json-data.test
  llvm/test/tools/llvm-symbolizer/output-style-json-frame.ll
  llvm/test/tools/llvm-symbolizer/sym-verbose.test
  llvm/test/tools/llvm-symbolizer/sym.test
  llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157210.547548.patch
Type: text/x-patch
Size: 28880 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230806/e90a1459/attachment.bin>