[PATCH] D157136: [LLD][COFF] Handle 'label' symbols when they point to a COMDAT section

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added inline comments.


================
Comment at: lld/COFF/InputFiles.cpp:628
+  // A comdat symbol consists of two symbol table entries, and a number of
+  // optional 'label' symbols.
   // The first symbol entry has the name of the section (e.g. .text), fixed
----------------
Interesting.  I think that we should add a comment about this impacts identity and comparison.  Does this change in definition have any impact on ICF?  IIRC, we did have a minor difference between link and lld in that regard.


================
Comment at: lld/COFF/InputFiles.h:267
+      std::vector<std::pair<DefinedRegular *,
+                            const llvm::object::coff_aux_section_definition *>>
+          &comdatDefs,
----------------
Can we use a typedef for the `std::vector<std::pair<DefinedRegular *, const llvm::object::coff_aux_section_definition *>>`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157136/new/

https://reviews.llvm.org/D157136