[PATCH] D156793: [TailCallElim] Remove the readonly attribute of byval.

[DianQK via Phabricator via llvm-commits]

DianQK added a comment.

In my mind, this is a worse case of mis-compilation.

With the current discussion, we have three methods to address it:

1. Remove the readonly attribute, which is safe with byval.
2. Do not add the readonly attribute to byval.
3. Prevent the tail recursion elimination.

First, all three methods can solve this problem.
But I prefer the first one, and I think there is less opportunity to prevent other optimizations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156793/new/

https://reviews.llvm.org/D156793