[PATCH] D157061: [SampleProfile] Potential use after move in SampleProfileLoader::promoteMergeNotInlinedContextSamples
William Junda Huang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 4 18:49:54 PDT 2023
huangjd added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1660-1663
+ if (ReportProfileStaleness || PersistProfileStaleness || SalvageStaleProfile)
+ MatchingManager =
+ std::make_unique<SampleProfileMatcher>(
+ const_cast<Module&>(*F.getParent()), *Reader, ProbeManager.get());
----------------
wlei wrote:
> Curious why we need to reset the `SampleProfileMatcher`?
Removed. This field does not need to be updated
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157061/new/
https://reviews.llvm.org/D157061
More information about the llvm-commits
mailing list