[PATCH] D157133: [AMDGPU] Extend CalculateByteProvider to capture vectors and signed

[Jeffrey Byrnes via Phabricator via llvm-commits]

jrbyrnes added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:10440
 
+  case ISD::ANY_EXTEND:
+  case ISD::SIGN_EXTEND:
----------------
arsenm wrote:
> handling any_extend here seems dangerous, can you do that in a separate patch? It might be correct but I'd rather keep it separate
No problem -- I would think it is correct as we only ever take the non extension bits. Either way, I'll look at it separately. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157133/new/

https://reviews.llvm.org/D157133